Jcerjak plip10359 security controlpanel #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….controlpanel"" This reverts commit f6f4456.
…jcerjak/Products.CMFPlone into jcerjak-plip10359-security-controlpanel
| >>> self.assertFalse('Changes saved.' in browser.contents) | ||
| >>> browser.open('http://nohost/plone/logout') | ||
|
|
||
| A >>> browser.open('http://nohost/plone/@@personal-information') |
There was a problem hiding this comment.
@vangheem We moved the security control panel to use the plone.app.registry-based control panels (#216). It seems this breaks the csrf protection, so I had to comment out that test. The _authenticator form field is present. Though, it seems it does not have any effect what value it holds. Would you mind having a look or give us some pointers how we could fix that? cc @jcerjak
There was a problem hiding this comment.
@vangheem Is it possible that the csrf protection never has been implemented for plone.app.registry?
tisto
added a commit
that referenced
this pull request
Dec 14, 2014
…panel Jcerjak plip10359 security controlpanel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.